fix(rss): handle self-closing XML elements correctly #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix RSS parsing to properly handle self-closing (empty) XML elements like `<atom:link href="..." />`. Previously, skip_element() was called for these elements expecting a closing tag that doesn't exist, which consumed subsequent XML events and broke parsing. Changes: - Add is_empty flag propagation through parse_channel and parse_item - Skip skip_element() calls when is_empty=true at both channel and item level - Fix enclosure element handling (always self-closing) - Populate feed.feed.image from itunes:image for empty elements Closes #45
github-actions
bot
added
type: tooling
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #46 +/- ##
==========================================
- Coverage 91.84% 91.68% -0.16%
==========================================
Files 34 34
Lines 7758 7816 +58
==========================================
+ Hits 7125 7166 +41
- Misses 633 650 +17
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Update version in all manifests: - Cargo.toml (workspace) - package.json (Node.js) - pyproject.toml (Python) - uv.lock Update CHANGELOG.md with 0.4.2 release notes for issue #45 fix.
github-actions
bot
added
type: documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
skip_element()was called for empty elements expecting a closing tag<item>elementsChanges
is_emptyflag propagation throughparse_channelandparse_itemfunctionsskip_element()calls whenis_empty=trueat both channel and item levelfeed.feed.imagefromitunes:imagefor empty elementsTest Plan
-D warningscargo +nightly fmtcargo deny checkpassesCloses #45